carbon: Tag filter doesn't honor type knob
What package(s) are you using?
-
carbon-components -
carbon-components-react
Detailed description
Describe in detail the issue you’re having.
type is not being honor on a filter (tag variant)
Is this issue related to a specific component?
Yes the Tag component
What did you expect to happen? What happened instead? What would you like to see changed?
Expect the color to change to the color I picked. For example “gray”
What browser are you working in?
Chrome
What version of the Carbon Design System are you using?
“carbon-components”: “^10.3.0”, “carbon-components-react”: “^7.2.0”,
What offering/product do you work on? Any pressing ship or release dates we should be aware of?
Watson for Clinical Trial Matching
Steps to reproduce the issue
Change the type knob and see it works for Tab but NOT for the filter variant. http://react.carbondesignsystem.com/?path=/story/tag--filter
Additional information
- Screenshots or code
- Notes
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 26 (16 by maintainers)
Hey, just wanted to check on the status of this one since we are facing the same issue.
@laurenmrice What do you think about a temporary solution where we say the hover color is always the next darker (or lighter) step of the respective color. So if the tag is teal and therefore using Teal20 as the background color, the hover would be Teal 30. And then once the design team has created the hover values for the colors, we can change them.
This can be closed, I can make a new issue to transfer hover colors for components when they have a solution. 👍🏻
I opened a PR implementing the temporary solution described earlier in this issue: #5382
@emyarod that issue is only for interactive tokens, it isn’t used to generate a hover color for every color token we have. The same tool could be used to generate those values though maybe.
Yes, we definitely want this feature for Filterable Tag. Design currently has the specs for the background and text/icon color. But we currently are still working on values for the hover colors on the icon.
@emyarod Thanks!
@emyarod Can you reopen this defect or should I open a new issue with the same issue?